Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Enable 3D in Handover sidesheet #958

Merged
merged 8 commits into from
Apr 22, 2024
Merged

🎁 Enable 3D in Handover sidesheet #958

merged 8 commits into from
Apr 22, 2024

Conversation

kjellhaaland
Copy link
Contributor

@kjellhaaland kjellhaaland commented Apr 17, 2024

Short summary

Added 3D ModelViewer tab to Handover sidesheet.

Link to issue: #940

PR Checklist

  • I have performed a self-review of my own code
  • I have written a short summary of my changes in the PR
  • I have linked related issue to the PR

Tip

To deploy the PR to Test, use the Manual deploy fusion app TEST🚀 action.
Remember to deploy any backend changes to Test as well!

Caution

⛔ I understand by merging my PR, the changes will be deployed to production immediately ⛔

@kjellhaaland kjellhaaland self-assigned this Apr 17, 2024
@kjellhaaland kjellhaaland marked this pull request as ready for review April 17, 2024 12:08
@kjellhaaland kjellhaaland requested review from Gustav-Eikaas and a team as code owners April 17, 2024 12:08
Copy link
Contributor

@Gustav-Eikaas Gustav-Eikaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good too me! Fix comments

Copy link
Contributor

@Gustav-Eikaas Gustav-Eikaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjellhaaland kjellhaaland merged commit 5f90a41 into main Apr 22, 2024
4 checks passed
@kjellhaaland kjellhaaland deleted the 940-handover-3d branch April 22, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛: ModelViewer : ModelViewer fails to load model when switching between items
2 participants