Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove caching in the user info endpoint in the backend #192

Merged

Conversation

ashukequinor
Copy link
Contributor

@ashukequinor ashukequinor commented Dec 6, 2024

fix: remove caching in the user info endpoint in the backend

#108

@ashukequinor ashukequinor changed the title chor: remove caching in the user info endpoint in the backend fix: remove caching in the user info endpoint in the backend Dec 6, 2024
@vehecap
Copy link

vehecap commented Dec 6, 2024

Try to remove warnings before merging.

@ashukequinor ashukequinor reopened this Dec 9, 2024
@ashukequinor
Copy link
Contributor Author

warning has been removed by @SupraEQNR in his PR so merging without fix of warning.

@ashukequinor ashukequinor requested a review from vehecap December 10, 2024 10:41
Copy link

@vehecap vehecap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave the UserSecretsId in the project file. If you remove it, you will have to add all the secrets in secrets.json again next time you want to run it.

{
_msSqlContainer = new MsSqlBuilder()
.WithImage(
"mcr.microsoft.com/mssql/server:2022-latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we can make this changes into API.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I don't see any way to configure image from yml as testcontainer library configured with it's own configuration.
I think we can change configuration from code only.

@ashukequinor ashukequinor merged commit f1cce90 into main Dec 12, 2024
3 checks passed
@ashukequinor ashukequinor deleted the fix/No-user-premission-validation-for-decline-endpoint branch December 12, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants