Fix CI, add wheels, adjust for SCM policy #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With new numpy-1.26.0 our build fails on s390x as numpy wheels are not supplied but built and openblas is expected from this version [1] openblas library makes numpy somewhat faster and is available for installation, so we go for it. [1] See Numpy https://github.com/numpy/numpy/ issue 24703
It's been well over a year since Python 3.6 EOL, everyone should have migrated away already.
Our wheels build fail for python 3.9 and later as runs now collect numpy-1.26.0 which requires newer gcc than available on manylinux2010. Thus we bump our manylinux version which has newer tools installed.
We have a problem for i686 architecture. New 1.26.0 numpy by default require blas library. [1] And it seems like required openblas / epel package is not available for i686, so we can't use it. It doesn't seem feasible to deal with all of that, so instead we allow building without blas library. [1] See Numpy https://github.com/numpy/numpy/ issue 24703
achaikou
force-pushed
the
ci_and_wheels_and_scm
branch
4 times, most recently
from
3b118df
to
3154db8
Compare
achaikou
changed the title
sveinung-r
approved these changes
Oct 30, 2023
achaikou
force-pushed
the
ci_and_wheels_and_scm
branch
from
3154db8
to
c9e5a76
Compare
We got request to build dlisio on alpine, which means there might be a need for it for our other users. However we shall build wheels only for x86_64 architecture. Building on other architectures takes ages and will probably surpass github timeouts anyway. It is also unlikely our users even need it.
We previously skipped wheels for windows 32 as numpy didn't supply them for win32 starting from python 3.10. They do now though.
Unfortunately at the moment as dlisio is no longer in active development phase, team doesn't have enough capacity to deal with external PRs in an efficient manner.
Add standard security template.
Note that we have to copy lots of code because it seems like toml files do now allow to share flow any other way.
achaikou
force-pushed
the
ci_and_wheels_and_scm
branch
from
c9e5a76
to
73ddb81
Compare
sveinung-r
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would need to test-publish and install stuff first and make sure version returns something reasonable.
Not sure version is used during build, so probably also something we can only check later.