Skip to content

Commit

Permalink
Change container registry username to secret
Browse files Browse the repository at this point in the history
  • Loading branch information
GodVenn committed Apr 17, 2023
1 parent 4ff4cee commit 1476887
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy_to_development.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
Registry: ghcr.io
ImageName: ${{ github.repository }}
Tag: ${{ github.sha }}
RegistryUsername: ${{ github.actor }}
secrets:
RegistryUsername: ${{ github.actor }}
RegistryPassword: ${{ secrets.GITHUB_TOKEN }}

deploy:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy_to_staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ jobs:
Registry: auroraprodacr.azurecr.io
ImageName: robotics/flotilla
Tag: ${{ github.event.release.tag_name }}
RegistryUsername: ${{ secrets.ROBOTICS_ACRPUSH_DOCKER_APPLICATION_ID }}
secrets:
RegistryUsername: ${{ secrets.ROBOTICS_ACRPUSH_DOCKER_APPLICATION_ID }}
RegistryPassword: ${{ secrets.ROBOTICS_ACRPUSH_DOCKER_SECRET }}

deploy:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/publish_component.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@ on:
ImageName:
required: true
type: string
secrets:
RegistryUsername:
required: true
type: string
secrets:
RegistryPassword:
required: true

Expand All @@ -37,7 +36,7 @@ jobs:
uses: docker/login-action@v2
with:
registry: ${{ inputs.Registry }}
username: ${{ inputs.RegistryUsername }}
username: ${{ secrets.RegistryUsername }}
password: ${{ secrets.RegistryPassword }}

- name: Extract metadata (tags, labels) for Docker
Expand Down

0 comments on commit 1476887

Please sign in to comment.