Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename deck to inspection area #1902

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Rename deck to inspection area #1902

merged 2 commits into from
Dec 24, 2024

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Dec 18, 2024 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@andchiind andchiind added the improvement Improvement to existing functionality label Dec 18, 2024
@andchiind andchiind self-assigned this Dec 18, 2024
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Dec 18, 2024
@andchiind andchiind force-pushed the rename-deck branch 5 times, most recently from 239462a to e94839c Compare December 19, 2024 09:47
@andchiind andchiind marked this pull request as ready for review December 19, 2024 10:03
@andchiind andchiind mentioned this pull request Dec 19, 2024
Open
olaals
olaals approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@olaals olaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seem to be correctly renamed. LGTM

@andchiind
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@andchiind andchiind merged commit 2ea49ff into equinor:main Dec 24, 2024
15 checks passed
@andchiind andchiind deleted the rename-deck branch December 24, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olaals olaals olaals approved these changes

Assignees

@andchiind andchiind

Labels
database-change Will require migration improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andchiind @olaals