Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cli/dev proxy/join #2612

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/cli/dev proxy/join #2612

wants to merge 2 commits into from

Conversation

eikeland
Copy link
Contributor

Changes

  • Stopped using node:path join in app-proxy-plugin since it caused issues on windows

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: d44fc41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@equinor/fusion-framework-cli Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
poc-portal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🐞 bug Something isn't working 💾 CLI fusion framework CLI 🚧 chore maintaines work, (update deps, workflos ...) labels Nov 27, 2024
@eikeland eikeland self-assigned this Nov 27, 2024
@eikeland eikeland marked this pull request as ready for review November 27, 2024 14:46
@eikeland eikeland requested review from odinr and a team as code owners November 27, 2024 14:46
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.39% 1746 / 444286
🔵 Statements 0.39% 1746 / 444286
🔵 Functions 22.96% 203 / 884
🔵 Branches 37.1% 384 / 1035
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/cli/src/lib/plugins/app-proxy/app-proxy-plugin.ts 0% 0% 0% 0% 1-185
Generated in workflow #8106 for commit d44fc41 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odinr odinr Awaiting requested review from odinr odinr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@eikeland eikeland

Labels
🐞 bug Something isn't working 🚧 chore maintaines work, (update deps, workflos ...) 💾 CLI fusion framework CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eikeland