fix: powerbi styling issues (#618)

* fix: powerbi styling issues * add types * bump versions
equinor · May 8, 2024 · 4f536ec · 4f536ec
1 parent 1f414f8
commit 4f536ec
Show file tree

Hide file tree

Showing 8 changed files with 82 additions and 132 deletions.
diff --git a/packages/power-bi/package.json b/packages/power-bi/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@equinor/workspace-powerbi",
-  "version": "3.0.2",
+  "version": "3.0.3",
   "type": "module",
   "sideEffects": false,
   "license": "MIT",
@@ -26,34 +26,27 @@
     "dist"
   ],
   "dependencies": {
-    "@equinor/eds-core-react": "^0.28.0",
-    "@equinor/eds-icons": "^0.18.0",
-    "@equinor/eds-tokens": "^0.9.0",
-    "@tanstack/react-query": "^5.32.0",
-    "markdown-to-jsx": "^7.4.7",
-    "powerbi-client": "^2.23.1",
-    "powerbi-client-react": "^1.4.0",
-    "react-error-boundary": "^4.0.13",
-    "react-sortablejs": "^6.1.4",
-    "react-virtual": "^2.10.4",
-    "sortablejs": "^1.15.2"
-  },
-  "peerDependencies": {
-    "react": ">= 16.8.0",
-    "react-dom": ">= 16.8.0",
-    "react-is": ">= 16.8.0",
-    "styled-components": "^5.3.5"
+    "@equinor/eds-core-react": "^0",
+    "@equinor/eds-icons": "^0",
+    "@equinor/eds-tokens": "^0",
+    "@tanstack/react-query": "^5",
+    "markdown-to-jsx": "^7",
+    "powerbi-client": "^2",
+    "powerbi-client-react": "^1",
+    "react-error-boundary": "^4",
+    "react-sortablejs": "^6",
+    "react-virtual": "^2",
+    "sortablejs": "^1",
+    "react": "^18",
+    "react-dom": "^18",
+    "react-is": "^18",
+    "styled-components": "^6"
   },
   "devDependencies": {
-    "@types/react": "^18.3.1",
-    "@types/react-dom": "^18.3.0",
-    "@types/sortablejs": "^1.15.8",
-    "@types/styled-components": "^5.1.34",
-    "react": "^18.3.1",
-    "react-dom": "^18.3.1",
-    "react-is": "^18.3.1",
-    "styled-components": "^6.1.8",
-    "typescript": "^5.4.5"
+    "@types/sortablejs": "^1",
+    "@types/react": "^18",
+    "@types/react-dom": "^18",
+    "typescript": "^5"
   },
   "repository": {
     "type": "git",
@@ -62,3 +55,4 @@
   },
   "gitHead": "6407f12589214b96228ab87d32a211f7c1cd6ba4"
 }
+
diff --git a/packages/power-bi/src/lib/components/filterItem/filterItem.styles.ts b/packages/power-bi/src/lib/components/filterItem/filterItem.styles.ts
@@ -15,7 +15,7 @@ export const StyledCheckboxItem = styled.div`
     white-space: nowrap;
     cursor: pointer;
   }
-  :hover {
+  &:hover {
     background-color: ${tokens.colors.interactive.primary__selected_hover.rgba};
   }
 `;
diff --git a/packages/power-bi/src/lib/components/filterItemCheckbox/filterItemCheckbox.styles.ts b/packages/power-bi/src/lib/components/filterItemCheckbox/filterItemCheckbox.styles.ts
@@ -33,7 +33,7 @@ export const StyledFilterItemWrap = styled.div`
       padding-right: 2px;
     }
   }
-  :hover {
+  &:hover {
     background-color: ${tokens.colors.interactive.primary__selected_hover.rgba};
   }
 `;
diff --git a/packages/power-bi/src/lib/components/filterItems/filterItems.styles.ts b/packages/power-bi/src/lib/components/filterItems/filterItems.styles.ts
@@ -10,7 +10,7 @@ export const StyledFilterGroupContainer = styled.div`
 export const StyledCheckboxWrap = styled.span`
   height: 100%;
   overflow-x: hidden;
-  overflow-y: scroll;
+  overflow-y: auto;
   width: 100%;
   span {
     padding: 2px;

diff --git a/packages/power-bi/src/lib/components/toggleHideFilterPopover.tsx/ToggleHideFilterPopover.tsx b/packages/power-bi/src/lib/components/toggleHideFilterPopover.tsx/ToggleHideFilterPopover.tsx
@@ -54,7 +54,7 @@ export const ToggleHideFilterPopover = ({
           <Popover.Header>
             <Popover.Title>Filter types</Popover.Title>
           </Popover.Header>
-          <Popover.Content style={{ maxHeight: '60vh', overflowY: 'scroll', overflowX: 'hidden' }}>
+          <Popover.Content style={{ maxHeight: '60vh', overflowY: 'auto', overflowX: 'hidden' }}>
             <PopoverList>
               <ReactSortable
                 animation={200}

diff --git a/packages/power-bi/src/lib/components/virtualList/VirtualList.tsx b/packages/power-bi/src/lib/components/virtualList/VirtualList.tsx
@@ -57,7 +57,7 @@ const FilterItemValue = memo(VirtualFilterItemCheckbox);
 
 const Parent = styled.div`
   height: 100%;
-  overflow-y: scroll;
+  overflow-y: auto;
   overflow-x: hidden;
   ::-webkit-scrollbar-thumb {
     background: ${tokens.colors.ui.background__medium.hex};

diff --git a/packages/workspace-fusion/package.json b/packages/workspace-fusion/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@equinor/workspace-fusion",
-  "version": "9.0.5",
+  "version": "9.0.6",
   "type": "module",
   "sideEffects": false,
   "license": "MIT",
@@ -105,32 +105,25 @@
     }
   },
   "dependencies": {
-    "@equinor/eds-core-react": "0.27.0",
-    "@equinor/eds-icons": "^0.17.0",
-    "@equinor/eds-tokens": "0.9.0",
+    "@equinor/eds-core-react": "^0",
+    "@equinor/eds-icons": "^0",
+    "@equinor/eds-tokens": "^0",
     "@equinor/workspace-ag-grid": "workspace:^",
     "@equinor/workspace-filter": "workspace:^",
     "@equinor/workspace-garden": "workspace:^",
     "@equinor/workspace-powerbi": "workspace:^",
     "@equinor/workspace-react": "workspace:^",
-    "@tanstack/react-query": "^5.32.0",
+    "@tanstack/react-query": "^5",
     "re-resizable": "^6.9.16",
-    "react-error-boundary": "^4.0.13",
-    "vite-plugin-environment": "^1.1.3",
-    "react": ">= 18",
-    "react-dom": ">= 18"
-  },
-  "peerDependencies": {
-    "styled-components": ">= 5"
+    "react-error-boundary": "^4",
+    "react": "^18",
+    "react-dom": "^18",
+    "styled-components": "^6"
   },
   "devDependencies": {
-    "@types/jest": "29.5.12",
-    "@types/react": "^18.3.1",
-    "@types/react-dom": "^18.3.0",
-    "@types/styled-components": "^5.1.34",
+    "@types/react": "^18",
+    "@types/react-dom": "^18",
     "@vitejs/plugin-react": "^4.2.1",
-    "rollup-plugin-inject-process-env": "^1.3.1",
-    "styled-components": "^6.1.8",
     "typescript": "^5.4.5",
     "vite": "^5.2.10"
   },