feat: Make table height optional (#645)

equinor · Oct 18, 2024 · bf4aca9 · bf4aca9
1 parent 056616d
commit bf4aca9
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/packages/ag-grid/package.json b/packages/ag-grid/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@equinor/workspace-ag-grid",
-  "version": "3.0.2",
+  "version": "3.0.3",
   "type": "module",
   "private": false,
   "sideEffects": false,

diff --git a/packages/ag-grid/src/lib/components/ClientGrid.tsx b/packages/ag-grid/src/lib/components/ClientGrid.tsx
@@ -3,7 +3,7 @@ import { Grid } from './Grid';
 import { AgGridReactProps } from '@ag-grid-community/react';
 
 export type ClientGridProps<TData> = {
-  height: number;
+  height?: number;
   gridOptions?: GridOptions<TData>;
   rowData: TData[];
   colDefs: ColDef[];

diff --git a/packages/ag-grid/src/lib/components/Grid.tsx b/packages/ag-grid/src/lib/components/Grid.tsx
@@ -7,7 +7,7 @@ import { AgGridReact, AgGridReactProps } from '@ag-grid-community/react';
 import { ThemeProvider, theme } from '@equinor/fusion-react-styles';
 
 type GridProps<TData> = {
-  height: number;
+  height?: number; // height is now optional
 } & AgGridReactProps<TData>;
 
 ModuleRegistry.registerModules([ClientSideRowModelModule, ServerSideRowModelModule]);
@@ -23,8 +23,10 @@ export function Grid<TData>(props: GridProps<TData>) {
 export function InnerGrid<TData>({ columnDefs, gridOptions, height, rowData, modules, ...rest }: GridProps<TData>) {
   const styles = useStyles() as { root: string; grid: string };
 
+  const style = height ? { height } : {};
+
   return (
-    <StyledGridWrapper style={{ height }} className={`${styles.root} ag-theme-alpine-fusion`}>
+    <StyledGridWrapper style={style} className={`${styles.root} ag-theme-alpine-fusion`}>
       <AgGridReact
         rowHeight={32}
         groupDisplayType={'multipleColumns'}

diff --git a/packages/workspace-fusion/package.json b/packages/workspace-fusion/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@equinor/workspace-fusion",
-  "version": "9.0.16",
+  "version": "9.0.17",
   "type": "module",
   "sideEffects": false,
   "license": "MIT",