Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add cjs esm interop for ag-grid #549

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Conversation

Gustav-Eikaas
Copy link
Contributor

@Gustav-Eikaas Gustav-Eikaas commented Dec 4, 2023

Added support for CJS and ESM interop. Using tsup as build tool. Verified with arethetypeswrong.

ag-grid: ✅ check here
filter: ✅ check here
garden: ✅ check here
power-bi: ✅ check here
workspace-react: ✅ check here
workspace-fusion: ✅ check here

Workspace fusion isnt perfect due to compatibility issues with default exports in CJS and older versions of node

@Gustav-Eikaas Gustav-Eikaas added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit 04209ea Dec 5, 2023
4 checks passed
@Gustav-Eikaas Gustav-Eikaas deleted the feat/esm-cjs-interop branch December 5, 2023 12:14
@Gustav-Eikaas Gustav-Eikaas linked an issue Dec 19, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CJS/ESM interop (might make package unusable in other projects if not fixed) 🎁: CJS/ESM interop
2 participants