Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: reorder code in PhaseEos init, remove logging #1145

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner October 24, 2024 12:25
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 37.17%. Comparing base (75f177a) to head (5b0852c).

Files with missing lines Patch % Lines
src/main/java/neqsim/thermo/phase/PhaseEos.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1145      +/-   ##
============================================
- Coverage     37.17%   37.17%   -0.01%     
  Complexity     5693     5693              
============================================
  Files           713      713              
  Lines         70729    70726       -3     
  Branches       8117     8116       -1     
============================================
- Hits          26295    26293       -2     
  Misses        42815    42815              
+ Partials       1619     1618       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmfstatoil asmfstatoil merged commit 4a6bd7e into equinor:master Oct 24, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the refact_init branch October 24, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants