refact: make PhysicalPropertyMethod abstract and rewrite with import #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmfstatoil
force-pushed
the
ref_physicalpropertymethods
branch
from
8eff55e
to
52fb7cb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1151 +/- ##
============================================
- Coverage 37.19% 37.18% -0.02%
+ Complexity 5708 5705 -3
============================================
Files 715 715
Lines 70730 70726 -4
Branches 8122 8122
============================================
- Hits 26311 26301 -10
- Misses 42800 42806 +6
Partials 1619 1619 ☔ View full report in Codecov by Sentry. |
asmfstatoil
force-pushed
the
ref_physicalpropertymethods
branch
6 times, most recently
from
70a950c
to
faec1d1
Compare
asmfstatoil
force-pushed
the
ref_physicalpropertymethods
branch
2 times, most recently
from
f161ab6
to
79b869b
Compare
asmfstatoil
force-pushed
the
ref_physicalpropertymethods
branch
from
79b869b
to
295616b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.