refact: getPhases()[k] -> getPhase(k) #1190

asmfstatoil · 2024-11-22T14:16:15Z

No description provided.

EvenSol · 2024-11-25T17:56:38Z

src/main/java/neqsim/thermodynamicoperations/flashops/Flash.java

        }
        system.init(1);
        // logger.info("solid phase will form..." + system.getNumberOfPhases());
        // logger.info("freezing component " + solid);
        system.setBeta(system.getNumberOfPhases() - 1, frac);
        system.initBeta();
        system.setBeta(system.getNumberOfPhases() - 1,
-            system.getPhases()[3].getComponent(solid).getNumberOfmoles()
-                / system.getNumberOfMoles());
+            system.getPhase(3).getComponent(solid).getNumberOfmoles() / system.getNumberOfMoles());


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol · 2024-11-25T17:57:04Z

src/main/java/neqsim/thermodynamicoperations/flashops/Flash.java

@@ -397,36 +397,35 @@ public void solidPhaseFlash() {
        tempVar[k] = system.getPhase(0).getComponent(k).getz();
        for (int i = 0; i < system.getNumberOfPhases() - 1; i++) {
          tempVar[k] -=
-              system.getBeta(i) * system.getPhases()[3].getComponent(k).getFugacityCoefficient()
+              system.getBeta(i) * system.getPhase(3).getComponent(k).getFugacityCoefficient()


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol

I thin every time we need to use solid phases like solid, hdyrate etc., we need to use the phase array.

EvenSol · 2024-11-25T17:57:33Z

src/main/java/neqsim/thermodynamicoperations/flashops/Flash.java

                  / system.getPhase(i).getComponent(k).getFugacityCoefficient();
        }

        if (tempVar[k] > 0.0 && tempVar[k] > frac) {
          solidPhase = true;
          solid = k;
          frac = tempVar[k];
-          for (int p = 0; p < system.getPhases()[0].getNumberOfComponents(); p++) {
-            system.getPhases()[3].getComponent(p).setx(1.0e-20);
+          for (int p = 0; p < system.getPhase(0).getNumberOfComponents(); p++) {


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol · 2024-11-25T17:58:56Z

src/main/java/neqsim/thermodynamicoperations/flashops/PHflashSingleComp.java

@@ -68,7 +68,7 @@ public void run() {
     * double solidEnthalpy = 0.0;
     *
     * if (system.doSolidPhaseCheck()) { system.init(3, 3); solidEnthalpy =
-     * system.getPhases()[3].getEnthalpy() / system.getPhases()[3].getNumberOfMolesInPhase()
+     * system.getPhase(3).getEnthalpy() / system.getPhase(3).getNumberOfMolesInPhase()


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol · 2024-11-25T17:59:33Z

src/main/java/neqsim/thermodynamicoperations/flashops/SolidFlash.java

@@ -137,7 +137,7 @@ public void calcE() {
    // system.getBeta(system.getNumberOfPhases()-1) /
    // system.getPhase(3).getComponent(solidComponent).getFugacityCoefficient();
    E[solidComponent] = system.getPhase(0).getComponent(solidComponent).getz()
-        / system.getPhases()[3].getComponents()[solidComponent].getFugacityCoefficient();
+        / system.getPhase(3).getComponents()[solidComponent].getFugacityCoefficient();


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol · 2024-11-25T18:00:00Z

src/main/java/neqsim/thermodynamicoperations/flashops/SolidFlash.java

-          1.0 - system.getPhases()[3].getComponents()[solidComponent].getFugacityCoefficient()
-              / system.getPhase(k).getComponent(solidComponent).getFugacityCoefficient();
-      for (int i = 0; i < system.getPhases()[0].getNumberOfComponents(); i++) {
+      dQdbeta[k] = 1.0 - system.getPhase(3).getComponents()[solidComponent].getFugacityCoefficient()


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol · 2024-11-25T18:00:37Z

src/main/java/neqsim/thermodynamicoperations/flashops/SolidFlash1.java

        if (i != solidIndex) {
          system.getPhase(k).getComponent(i).setx(system.getPhase(0).getComponent(i).getz() / E[i]
              / system.getPhase(k).getComponent(i).getFugacityCoefficient());
        } else {
          system.getPhase(k).getComponent(i)
-              .setx(system.getPhases()[3].getComponent(i).getFugacityCoefficient()
+              .setx(system.getPhase(3).getComponent(i).getFugacityCoefficient()


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol · 2024-11-25T18:03:45Z

src/main/java/neqsim/thermodynamicoperations/flashops/SolidFlash12.java


    for (int k = 0; k < system.getPhase(0).getNumberOfComponents(); k++) {
      if (system.getTemperature() > system.getPhase(0).getComponent(k)
          .getTriplePointTemperature()) {
        solidCandidate[k] = -10;
      } else {
        solidCandidate[k] = system.getPhase(0).getComponent(k).getz();
-        system.getPhases()[3].getComponent(k).setx(1.0);
+        system.getPhase(3).getComponent(k).setx(1.0);


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol · 2024-11-25T18:03:53Z

src/main/java/neqsim/thermodynamicoperations/flashops/SolidFlash12.java


        for (int i = 0; i < system.getNumberOfPhases(); i++) {
-          solidCandidate[k] -= system.getPhases()[3].getComponent(k).fugcoef(system.getPhases()[3])
+          solidCandidate[k] -= system.getPhase(3).getComponent(k).fugcoef(system.getPhase(3))


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol · 2024-11-25T18:04:00Z

src/main/java/neqsim/thermodynamicoperations/flashops/SolidFlash12.java

              / system.getPhase(i).getComponent(k).getFugacityCoefficient();
        }
      }
    }

    for (int i = 0; i < solidCandidate.length; i++) {
      if (solidCandidate[i] > 0.0) {
-        system.getPhases()[3].getComponent(i).setx(1.0);
+        system.getPhase(3).getComponent(i).setx(1.0);


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol · 2024-11-25T18:04:06Z

src/main/java/neqsim/thermodynamicoperations/flashops/SolidFlash12.java

        solidIndex = i;
        solidsNumber++;
      } else {
-        system.getPhases()[3].getComponent(i).setx(0.0);
+        system.getPhase(3).getComponent(i).setx(0.0);


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol · 2024-11-25T18:04:15Z

src/main/java/neqsim/thermodynamicoperations/flashops/SolidFlash12.java

-        solidCandidate -=
-            system.getPhases()[3].getComponent(solidIndex).fugcoef(system.getPhases()[3])
-                / system.getPhase(i).getComponent(solidIndex).getFugacityCoefficient();
+        solidCandidate -= system.getPhase(3).getComponent(solidIndex).fugcoef(system.getPhase(3))


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

EvenSol · 2024-11-25T18:08:47Z

src/main/java/neqsim/thermodynamicoperations/ThermodynamicOperations.java

@@ -1184,7 +1184,7 @@ public void hydrateFormationTemperature(int structure) throws IsNaNException {
    }

    for (int i = 0; i < system.getPhase(4).getNumberOfComponents(); i++) {
-      ((ComponentHydrate) system.getPhases()[4].getComponent(i)).setHydrateStructure(structure - 1);
+      ((ComponentHydrate) system.getPhase(4).getComponent(i)).setHydrateStructure(structure - 1);


In this case I beleive we have to used system.getPhases()[4] - as the hydrate phase is always number four (and getPhase(4) can point to a different phase.

EvenSol · 2024-11-25T18:09:37Z

src/main/java/neqsim/thermodynamicoperations/flashops/Flash.java

          }
-          system.getPhases()[3].getComponents()[solid].setx(1.0);
+          system.getPhase(3).getComponents()[solid].setx(1.0);


In this case I beleive we have to used system.getPhases()[3] - as the solid phase is always number three (and getPhase(3) can point to a different phase.

asmfstatoil requested a review from EvenSol as a code owner November 22, 2024 14:16

asmfstatoil force-pushed the getPhases branch from dd8797c to 2a66106 Compare November 24, 2024 18:03

refact: getPhases()[k] -> getPhase(k)

ec36cf4

asmfstatoil force-pushed the getPhases branch from 2a66106 to ec36cf4 Compare November 25, 2024 13:16

EvenSol reviewed Nov 25, 2024

View reviewed changes

EvenSol requested changes Nov 25, 2024

View reviewed changes

EvenSol reviewed Nov 25, 2024

View reviewed changes

asmfstatoil marked this pull request as draft November 26, 2024 07:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refact: getPhases()[k] -> getPhase(k) #1190

refact: getPhases()[k] -> getPhase(k) #1190

asmfstatoil commented Nov 22, 2024

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

EvenSol left a comment

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

EvenSol Nov 25, 2024

refact: getPhases()[k] -> getPhase(k) #1190

Are you sure you want to change the base?

refact: getPhases()[k] -> getPhase(k) #1190

Conversation

asmfstatoil commented Nov 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EvenSol left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment