fix: tests

equinor · Nov 22, 2024 · aa69de7 · aa69de7
1 parent ee876b8
commit aa69de7
Showing 1 changed file with 9 additions and 18 deletions.
diff --git a/api/applications/applications_controller_test.go b/api/applications/applications_controller_test.go
@@ -361,12 +361,12 @@ func TestSearchApplicationsPost_WithJobs_ShouldOnlyHaveLatest(t *testing.T) {
 	commonTestUtils, controllerTestUtils, kubeclient, _, _, _, _, _ := setupTest(t, true, true)
 	apps := []applicationModels.Application{
 		{Name: "app-1", Jobs: []*jobModels.JobSummary{
-			{Name: "app-1-job-1", Started: createTimePtr("2018-11-12T11:45:26Z")},
+			{Name: "app-1-job-1", Started: createTime("2018-11-12T11:45:26Z")},
 		}},
 		{Name: "app-2", Jobs: []*jobModels.JobSummary{
-			{Name: "app-2-job-1", Started: createTimePtr("2018-11-12T12:30:14Z")},
-			{Name: "app-2-job-2", Started: createTimePtr("2018-11-20T09:00:00Z")},
-			{Name: "app-2-job-3", Started: createTimePtr("2018-11-20T09:00:01Z")},
+			{Name: "app-2-job-1", Started: createTime("2018-11-12T12:30:14Z")},
+			{Name: "app-2-job-2", Started: createTime("2018-11-20T09:00:00Z")},
+			{Name: "app-2-job-3", Started: createTime("2018-11-20T09:00:01Z")},
 		}},
 		{Name: "app-3"},
 	}
@@ -535,12 +535,12 @@ func TestSearchApplicationsGet_WithJobs_ShouldOnlyHaveLatest(t *testing.T) {
 	commonTestUtils, controllerTestUtils, kubeclient, _, _, _, _, _ := setupTest(t, true, true)
 	apps := []applicationModels.Application{
 		{Name: "app-1", Jobs: []*jobModels.JobSummary{
-			{Name: "app-1-job-1", Started: createTimePtr("2018-11-12T11:45:26Z")},
+			{Name: "app-1-job-1", Started: createTime("2018-11-12T11:45:26Z")},
 		}},
 		{Name: "app-2", Jobs: []*jobModels.JobSummary{
-			{Name: "app-2-job-1", Started: createTimePtr("2018-11-12T12:30:14Z")},
-			{Name: "app-2-job-2", Started: createTimePtr("2018-11-20T09:00:00Z")},
-			{Name: "app-2-job-3", Started: createTimePtr("2018-11-20T09:00:01Z")},
+			{Name: "app-2-job-1", Started: createTime("2018-11-12T12:30:14Z")},
+			{Name: "app-2-job-2", Started: createTime("2018-11-20T09:00:00Z")},
+			{Name: "app-2-job-3", Started: createTime("2018-11-20T09:00:01Z")},
 		}},
 		{Name: "app-3"},
 	}
@@ -2137,16 +2137,7 @@ func (f *testApplicationHandlerFactory) Create(accounts models.Accounts) Applica
 	return NewApplicationHandler(accounts, f.config, f.hasAccessToGetConfigMap)
 }
 
-func createTime(timestamp string) time.Time {
-	if timestamp == "" {
-		return time.Time{}
-	}
-
-	t, _ := time.Parse(time.RFC3339, timestamp)
-	return t
-}
-
-func createTimePtr(timestamp string) *time.Time {
+func createTime(timestamp string) *time.Time {
 	if timestamp == "" {
 		return &time.Time{}
 	}