Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate user is member of one of existing admin groups #538

Merged
merged 12 commits into from
Sep 22, 2023
Merged

Validate user is member of one of existing admin groups #538

merged 12 commits into from
Sep 22, 2023

Conversation

satr
Copy link
Contributor

@satr satr commented Sep 21, 2023

No description provided.

@satr satr self-assigned this Sep 21, 2023
nilsgstrabo
nilsgstrabo requested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@nilsgstrabo nilsgstrabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Added two comments
  • Also do validation on application create

api/applications/applications_handler.go Outdated Show resolved Hide resolved
api/applications/applications_handler.go Show resolved Hide resolved
nilsgstrabo
nilsgstrabo previously approved these changes Sep 22, 2023
View reviewed changes
@satr satr merged commit 93c89b5 into master Sep 22, 2023
1 check passed
@satr satr deleted the validate-user-is-member-of-one-of-existing-admin-groups branch September 22, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsgstrabo nilsgstrabo nilsgstrabo approved these changes

Assignees

@satr satr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satr @nilsgstrabo