Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies, fix linting #581

Merged
merged 7 commits into from
Jan 2, 2024
Merged

update dependencies, fix linting #581

merged 7 commits into from
Jan 2, 2024

Conversation

Richard87
Copy link
Contributor

No description provided.

@Richard87 Richard87 requested a review from satr January 2, 2024 09:33
@Richard87 Richard87 mentioned this pull request Jan 2, 2024
Closed
28 tasks
satr
satr requested changes Jan 2, 2024
View reviewed changes
api/alerting/alerting_controller.go Outdated
@@ -142,19 +145,25 @@ func UpdateEnvironmentAlertingConfig(accounts models.Accounts, w http.ResponseWr

var updateAlertingConfig alertingModels.UpdateAlertingConfig
if err := json.NewDecoder(r.Body).Decode(&updateAlertingConfig); err != nil {
radixhttp.ErrorResponse(w, r, err)
if err = radixhttp.ErrorResponse(w, r, err); err != nil {
log.Errorf("%s: failed to write response: %s", r.URL.Path, err.Error())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this logging to the method radixhttp.ErrorResponse to avoid repetition?
%v can be used for error
log.Errorf("%s: failed to write response: %v", r.URL.Path, err)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024 


BREAKING CHANGES:
=================
/applications/{appName}/jobs/{jobName}/logs/{stepName}:get - Request - Deleted endpoint
/applications/{appName}/jobs/{jobName}/pipelineruns/{pipelineRunName}/tasks/{taskName}/logs/{stepName}:get - Request - Deleted endpoint
compatibility test FAILED: 2 breaking changes detected

@Richard87 Richard87 merged commit 0034fdd into master Jan 2, 2024
6 checks passed
@Richard87 Richard87 deleted the update-dependencies branch January 2, 2024 12:30
@Richard87 Richard87 self-assigned this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satr satr satr approved these changes

Assignees

@Richard87 Richard87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Richard87 @satr