-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade horizontal scaling information (Keda) #633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions
// Component current average CPU utilization over all pods, represented as a percentage of requested CPU | ||
// | ||
// required: false | ||
// example: 70 | ||
// deprecated: use Triggers instead. Will be removed from Radix API 2025-01-01. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deprecated "annotation" is not propagated to swagger.json (if that was the intention), nor does it flag it as deprecated to the linters.
Applies to the next three field
Co-authored-by: Nils Gustav Stråbø <65334626+nilsgstrabo@users.noreply.github.com>
Co-authored-by: Nils Gustav Stråbø <65334626+nilsgstrabo@users.noreply.github.com>
Co-authored-by: Nils Gustav Stråbø <65334626+nilsgstrabo@users.noreply.github.com>
Example response:
Note: Limitations in Keda status/hpa status fields causes resource types to match on the first type (so the code below will be invalid for duplicate cpu and memory triggers (only the first of each type is correct, the other is duplicated)