More flaky timeouts #427
Merged
More flaky timeouts #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the Selenium tests on a plot axis title was sometimes timing out. This change doubles the timeout to 20s. For sure, 10s already seems long; if there's still an issue it may be another problem.
|
Can one of the admins verify this patch? |
kwinkunks
force-pushed
the
more-flaky-timeouts
branch
from
5a65075 to
766eb49
Compare
|
May be obviated by #424 |
xjules
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
I think it's good @kwinkunks to have it just in case, so 🚀 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Does not resolve but works on #426, which we're leaving open for more fixes if required.
Approach
We previously increased the timeout limit on similar tests in the same file; this commit doubles the timeout in the same way for the other functions.
Pre review checklist
Added appropriate labels