Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented collapsible group for structuring settings #262

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

rubenthoms
Copy link
Collaborator

No description provided.

@rubenthoms rubenthoms added the enhancement New feature or request label Aug 18, 2023
@rubenthoms rubenthoms self-assigned this Aug 18, 2023
@rubenthoms rubenthoms changed the title Implemented collapsible group icon for structuring settings Implemented collapsible group for structuring settings Aug 18, 2023
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified. Looks good!

Just one minor comment

{expanded ? <ChevronUpIcon className="w-4 h-4" /> : <ChevronDownIcon className="w-4 h-4" />}
</div>
<div
className={resolveClassNames("p-2 transition-[height] duration-500 ease-in-out", {
Copy link
Collaborator

@jorgenherje jorgenherje Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem to be affected by adjusting duration-500 of the transition. Tried e.g. duration-3000, and could not see it becoming slower.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, forgot to remove it. Done now.

@rubenthoms rubenthoms merged commit d0671bb into equinor:main Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants