Change findpeaks indexing to support pandas 3.0 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`df["foo"].iloc[bar] = xyz` is using chained indexing and then setting a value,
which is setting the value of a copy (in 3.0)
Changing this to use a single index, such as:
`df.iloc[bar, df.columns.get_loc("foo")] = xyz`
erdogant
approved these changes
Jan 13, 2025
|
Thank you for the updates! I will run some tests first and if all is fine, I will release a new version. |
|
@erdogant No problem. You may want to look over the rest for other incompatibilities with the new pandas version. These were the only ones that generated deprecation warnings with the code we used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
df["foo"].iloc[bar] = xyzis using chained indexing and then setting a value,which is setting the value of a copy (in pandas 3.0+)
Changing this to use a single index, such as:
df.iloc[bar, df.columns.get_loc("foo")] = xyzSee https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy for details.