Workers do not error out if the tasks cannot be placed.

erdos-project · May 7, 2024 · cc98325 · cc98325
1 parent 937eee0
commit cc98325
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/data/alibaba_loader.py b/data/alibaba_loader.py
@@ -114,7 +114,9 @@ def __init__(
         self._task_cpu_usage_min = self._flags.alibaba_loader_task_cpu_usage_min
         self._task_cpu_usage_max = self._flags.alibaba_loader_task_cpu_usage_max
         self._task_cpu_usage_random = self._flags.alibaba_loader_task_cpu_usage_random
-        self._alibaba_bump_resources_of_low_duration_task = self._flags.alibaba_bump_resources_of_low_duration_task
+        self._alibaba_bump_resources_of_low_duration_task = (
+            self._flags.alibaba_bump_resources_of_low_duration_task
+        )
 
     def _construct_workload_definitions(
         self,
@@ -551,9 +553,12 @@ def _convert_job_data_to_job_graph(
                     * self._task_cpu_multiplier
                 )
                 # bump up the resources of low duration tasks
-                if self._alibaba_bump_resources_of_low_duration_task and  task.actual_duration < 4:
+                if (
+                    self._alibaba_bump_resources_of_low_duration_task
+                    and task.actual_duration < 4
+                ):
                     resource_usage = self._task_cpu_usage_max
-                
+
                 job_resources_1 = Resources(
                     resource_vector={
                         Resource(name="Slot_1", _id="any"): resource_usage,

diff --git a/workers/workers.py b/workers/workers.py
@@ -602,7 +602,7 @@ def place_task(
                     f"[{','.join(t.unique_name for t in worker.get_placed_tasks())}]"
                 )
                 self._logger.error(error_message)
-                raise RuntimeError(error_message)
+                return False
             else:
                 strategy = execution_strategy