Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the environment bat file so it launches a command prompt #443

Closed
wants to merge 1 commit into from

Conversation

GoudaCouda
Copy link

Changed the environment bat file so it launches a command prompt. As before it would flash a prompt open and then close.

First PR so not sure if this is correct format or whatever

… before it would flash a prompt open and then close.
@danielw97
Copy link

Hi,
Although I'm not the maintainer, you will have to change the setup file I believe, as those batch files are unique to every install.
i.e. the way you've got it setup currently, the batch file is pointing to where your own installation of alltalk lives, as apposed to the needed change for when it's dynamically generated.
I don't have the code in front of me at the moment, although depending on if @erew123 gets back to you before then I should have time this weekend to point you in the right direction as to where the needed change would have to be made.
Thanks for your contribution though, as a fellow windows user as I was also observing this and would love to get it fixed.

@danielw97
Copy link

Hi again,
From a quick glance, you would have to modify atsetup.bat, try looking around line 620 or so and you should see what I mean.
Hth a bit.

@erew123
Copy link
Owner

erew123 commented Jan 5, 2025

Hi @GoudaCouda

Apologies for the late reply. Happy New Year.

@danielw97 is correct, these files are dynamically built and its this line you would modify https://github.com/erew123/alltalk_tts/blob/alltalkbeta/atsetup.bat#L608

Happy to do that or if you want to re-submit your PR with that change? Let me know!

Thanks

@erew123 erew123 closed this Jan 5, 2025
@erew123
Copy link
Owner

erew123 commented Jan 5, 2025

@GoudaCouda Just fyi its before the >> start_alltalk.bat you would add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants