Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Work around limitations with PHP_INT_MAX #12

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Conversation

localheinz
Copy link
Member

This pull request

  • works around limitations with PHP_INT_MAX

Follows #10.
Related to #7.

@localheinz localheinz self-assigned this Dec 25, 2023
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4132e53) 100.00% compared to head (37539f2) 98.34%.

Files Patch % Lines
src/Major.php 92.30% 1 Missing ⚠️
src/Minor.php 92.30% 1 Missing ⚠️
src/Patch.php 92.30% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##                main      #12      +/-   ##
=============================================
- Coverage     100.00%   98.34%   -1.66%     
- Complexity        62       66       +4     
=============================================
  Files             12       13       +1     
  Lines            158      181      +23     
=============================================
+ Hits             158      178      +20     
- Misses             0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz merged commit 42893a3 into main Dec 25, 2023
17 of 19 checks passed
@localheinz localheinz deleted the fix/php-int-max branch December 25, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants