-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-0012 - dApp-Wallet Web Bridge #23
Draft
rooooooooob
wants to merge
6
commits into
ergoplatform:master
Choose a base branch
from
rooooooooob:eip-0012
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Aug 10, 2020
-
Technical spec for wallet-dApp communication.
Configuration menu - View commit details
-
Copy full SHA for 720b188 - Browse repository at this point
Copy the full SHA 720b188View commit details
Commits on Aug 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c745a55 - Browse repository at this point
Copy the full SHA c745a55View commit details
Commits on Mar 12, 2021
-
Update EIP-0012 based on minor changes thought of during initial impl…
…ementation of it in Yoroi. Type definitions are specified using flow types now instead of some pseudo JS schema. API errors are added to all API calls to handle things that can go wrong for any call,e.g. internal error in the wallet, incorrect params specified to API calls. get_change_address() was added as an explicit API since it should be easy to support and allows for an easier way during tx creation rather than arbitrarily choosing an address from the used or unused API calls, which aren't garuanteed to be non-empty. add_external_box was removed as we are still unsure how any wallets would be able to implement it in any meaningful way. This could be reversed and have most wallets treat it as a no-op.
Configuration menu - View commit details
-
Copy full SHA for a47bce0 - Browse repository at this point
Copy the full SHA a47bce0View commit details
Commits on May 31, 2021
-
The id field has been removed, as well as the tx id/box id from outputs which are now BoxCandidates. This was only used before to help with interop with exisitng tooling but now that sigma-rust no longer requires these there's no reason to keep them around. They only made it more difficult to construct an unsigned transaction. Now one can be a lot more easily constructed even without using other tooling to calculate the IDs/etc.
Configuration menu - View commit details
-
Copy full SHA for d0d5d9a - Browse repository at this point
Copy the full SHA d0d5d9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3feb014 - Browse repository at this point
Copy the full SHA 3feb014View commit details
Commits on Jun 17, 2021
-
typo in type name Co-authored-by: Denys Zadorozhnyi <denys@zadorozhnyi.com>
Configuration menu - View commit details
-
Copy full SHA for b70f406 - Browse repository at this point
Copy the full SHA b70f406View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.