Removed 2 libraries with vulnerabilities #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satsen
force-pushed
the
remove-libs
branch
2 times, most recently
from
5b14db1
to
88390ae
Compare
kushti
approved these changes
Sep 8, 2024
aslesarenko
requested changes
Sep 12, 2024
lib-api/src/main/java/org/ergoplatform/appkit/BoxOperations.java
Outdated
Show resolved
Hide resolved
lib-impl/src/main/java/org/ergoplatform/appkit/impl/OutBoxBuilderImpl.scala
Outdated
Show resolved
Hide resolved
aslesarenko
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versions of Guava and Commons IO used in Appkit have vulnerabilities. Even if the vulnerable code might not be invoked (I didn't check), it's a bad look because all users of the library receive warnings. These libraries are not used much at all so removing them is the best solution.