Added new builder methods that take lists #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satsen
force-pushed
the
new-builder-methods
branch
from
7d84142
to
4055934
Compare
satsen
changed the title
satsen
force-pushed
the
new-builder-methods
branch
2 times, most recently
from
cde9203
to
8e697d9
Compare
satsen
force-pushed
the
new-builder-methods
branch
from
8e697d9
to
e6327a0
Compare
satsen
changed the title
satsen
force-pushed
the
new-builder-methods
branch
2 times, most recently
from
b22c0f2
to
245187d
Compare
satsen
force-pushed
the
new-builder-methods
branch
from
245187d
to
40360fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #245
Additionally, I made it so that
outBoxBuilder.tokens(empty)is allowed. I did not makeregisters(empty)allowed, but maybe I should. Perhaps only the methods taking Lists should allow it being empty, because it's easy to call a varargs method with no arguments by accident, but that makes it confusing.