-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adhere DEX orders to "limit order" behavior (single counter order) #13
base: develop
Are you sure you want to change the base?
Conversation
update compiler;
added regs to boxes in both cancel scenarios;
avoid fake token minting on buy order cancel
ergoplatform/ergo#1097 got me thinking if I can find a way to avoid minting the token on buy order cancellation (workaround for ergoplatform/sigmastate-interpreter#628) . It turned out that switching to |
formatting;
draft multiple counter orders support in seller contract; expose dex fee per token in R6;
the counter order;
…nter Adhere DEX order to limit order behaviour with multiple counter orders support
Require in the contracts that price difference was returned to the order's author.
For example, let's say we have a sell order with token price 5 ergs and buy order with token price 6 ergs. The contract must enforce 1 erg difference to be returned to the buyer(seller) depending on who's order was first.
This PR is only for single counter order. #14 is branched from it to add multiple counter order support.
Challenge 1.
Figure out how "select" proper counter orders without a 'sort' op. Example:
For older buy order (price 5 ergs, total 15 ergs) which is matched with 2 newer sell orders (price 5, 2 tokens), (price 4, 2 tokens) how to start "selecting" tokens from the second sell order and finish with the first order?
Without the solution, we'd have to limit to 1-1 (single counter order) order matching per swap tx.
Todo:
Continued in #14