EIP-37 implementation and activation #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
requested changes
Sep 27, 2022
src/main/scala/org/ergoplatform/mining/difficulty/DifficultyAdjustment.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/ergoplatform/nodeView/history/storage/modifierprocessors/HeadersProcessor.scala
Outdated
Show resolved
Hide resolved
pragmaxim
reviewed
Sep 27, 2022
...in/scala/org/ergoplatform/nodeView/history/storage/modifierprocessors/HeadersProcessor.scala
Show resolved
Hide resolved
aslesarenko
requested changes
Sep 27, 2022
src/main/scala/org/ergoplatform/mining/difficulty/DifficultyAdjustment.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/ergoplatform/mining/difficulty/DifficultyAdjustment.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/ergoplatform/nodeView/history/storage/modifierprocessors/HeadersProcessor.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/ergoplatform/nodeView/history/storage/modifierprocessors/HeadersProcessor.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/ergoplatform/nodeView/history/storage/modifierprocessors/HeadersProcessor.scala
Show resolved
Hide resolved
Co-authored-by: Alexander Slesarenko <aslesarenko@users.noreply.github.com>
…justment.scala Co-authored-by: Alexander Slesarenko <aslesarenko@users.noreply.github.com>
See above on testing. Unfortunately, automated tests would be tricky to do with our testing framework, will take a look how to do them. |
aslesarenko
approved these changes
Sep 27, 2022
greenhat
requested changes
Sep 27, 2022
| val limitedPredictiveDiff = if (predictiveDiff > lastDiff) { | ||
| predictiveDiff.min(lastDiff * 3 / 2) | ||
| } else { | ||
| predictiveDiff.max(lastDiff * 2) |
There was a problem hiding this comment.
Should it be lastDiff / 2? The same goes for uncompressedDiff.
There was a problem hiding this comment.
Sorry, my bad, fixed.
For tests, thinking to add some test vectors. Anything better we can do?
pragmaxim
approved these changes
Sep 27, 2022
greenhat
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains implementation and activation of EIP-37 described in ergoplatform/eips#79.
Activation: it is possible to activate EIP-37 after block #843,776 and before block #851,969 . For activation, 232 or more votes for activation required in last 256 blocks, with voting checked every 128 blocks (for blocks which height % 128 == 1), and immediate activation once threshold is met.
Also, in this PR:
offlineGenerationis nowtrueby default for the mainnet (which is what is needed by the pools all the time)