[6.0] Global.fromBigEndianBytes implementation #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslesarenko
approved these changes
Sep 30, 2024
| if (bytes.length > SBigInt.MaxSizeInBytes) { | ||
| throw SerializerException(s"BigInt value doesn't not fit into ${SBigInt.MaxSizeInBytes} bytes in fromBigEndianBytes") | ||
| } | ||
| CBigInt(new BigInteger(bytes.toArray)).asInstanceOf[T] |
There was a problem hiding this comment.
This should also satisfy the bit size for BigInt values, to catch the potential problem early.
See multiplication operation.
There was a problem hiding this comment.
done ,
CBigInt(new BigInteger(bytes.toArray).to256BitValueExact).asInstanceOf[T]
now
| @@ -516,7 +516,7 @@ class ErgoTreeSpecification extends SigmaDslTesting with ContractsTestkit with C | |||
| (SGlobal.typeId, Seq( | |||
| MInfo(1, groupGeneratorMethod), MInfo(2, xorMethod) | |||
| ) ++ (if (isV6Activated) { | |||
| Seq(MInfo(3, serializeMethod)) // methods added in v6.0 | |||
| Seq(MInfo(3, serializeMethod), MInfo(5, fromBigEndianBytesMethod)) // methods added in v6.0 | |||
There was a problem hiding this comment.
worth making a note about id = 4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new Global.fromBigEndianBytes[TNum] method is implemented in this PR, which can parse big-endian two's complement binary representation of TNum type.
example:
close #993