Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing non-methods ops to the parser layer. Part 2. #343

Merged
merged 2 commits into from
Dec 27, 2018
Merged

Add missing non-methods ops to the parser layer. Part 2. #343

merged 2 commits into from
Dec 27, 2018

Conversation

greenhat
Copy link
Member

@greenhat greenhat added the S-wip Status: Work in progress label Dec 27, 2018
@greenhat greenhat changed the title Add missing ops to the parser layer Add missing ops to the parser layer. Part 2. Dec 27, 2018
@greenhat greenhat changed the title Add missing ops to the parser layer. Part 2. Add missing non-methods ops to the parser layer. Part 2. Dec 27, 2018
@greenhat greenhat added S-ready-for-merge Status: This PR is ready for merge and removed S-wip Status: Work in progress labels Dec 27, 2018
ergomorphic
ergomorphic approved these changes Dec 27, 2018
View reviewed changes
Copy link
Collaborator

@ergomorphic ergomorphic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ergomorphic ergomorphic merged commit a29ac63 into master Dec 27, 2018
@catena2w catena2w deleted the i324-parser-layer-part2 branch June 18, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ergomorphic ergomorphic ergomorphic approved these changes

Assignees
No one assigned
Labels
S-ready-for-merge Status: This PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greenhat @ergomorphic