-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing ops and predefined functions for 2.0 #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
force-pushed
the
i324-predef-funcs
branch
from
February 21, 2019 09:48
61b06e1
to
7526055
Compare
…n.elemType on the fly);
add OneArgumentOperationSerializer (Negation, BitInversion);
implement SigmaDslBuilder.byteArrayToLong in RuntimeCosting and TreeBuilding;
switched byteArrayToLong test to go through costing;
greenhat
force-pushed
the
i324-predef-funcs
branch
from
February 22, 2019 14:40
302d6ee
to
1daf285
Compare
aslesarenko
requested changes
Feb 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
src/main/scala/sigmastate/serialization/MethodCallSerializer.scala
Outdated
Show resolved
Hide resolved
use withDefaultSize in ByteArrayToLong costing;
revert hack for BigInt type in func;
fix SFunc.typeParams to hold tpeParams; (de)serialize type idents in MethodCall.typeSubst using index in SFunc.tpeParams list;
aslesarenko
reviewed
Feb 24, 2019
src/main/scala/sigmastate/serialization/MethodCallSerializer.scala
Outdated
Show resolved
Hide resolved
…pes in the order of SGenericType.typeParams); fix Coll.zip() to include tOV type subst in TreeBuilding;
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#324
Todo:
ZKProofBlock
(de)serialization?byteArrayToLong
;xorOf
;Box.getReg
;!
(logical Not);-
(negation);^
(logical XOR) Finish BinXor implementation #424;~
(bitwise inversion) Implement bitwise numeric OR, AND, XOR, inversion, bit shifts #474;|
(bitwise OR for Numeric) Implement bitwise numeric OR, AND, XOR, inversion, bit shifts #474;&
(bitwise AND for Numeric) Implement bitwise numeric OR, AND, XOR, inversion, bit shifts #474;^
(bitwise XOR for Numeric) Implement bitwise numeric OR, AND, XOR, inversion, bit shifts #474;<<
,>>
,>>>
(bit shifts for Numeric) Implement bitwise numeric OR, AND, XOR, inversion, bit shifts #474;outerJoin
Implement outerJoin on collections #472;executeFromVar
Finish executeFromX implementation #443;substConstants
;