Release Candidate v5.0.10 #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix JS tests and publish script
Cross-compile ErgoScript compiler to JS
Add Sigma.JS types
* CI: run js tests and publish snapshots * CI: add npm publishing tag * CI: fix ci.yml file * CI: adjust npm setup step * CI: temporarily skip non js related steps * CI: set node registry URL * CI: use nodejs v20 * CI: add stable release * CI: remove npm cache * CI: fix npm caching issues * CI: add cache dependency path * remove accidentally committed yarn.lock file
* add ErgoTree `template` and `templateHex` method and fix type exporting * Simplify package installing instructions
ErgoTree template
kushti
approved these changes
Jul 31, 2023
kushti
approved these changes
Jul 31, 2023
| * @param hex a hexadecimal string representing the serialized ErgoTree | ||
| */ | ||
| def fromHex(hex: String): ErgoTree = { | ||
| val bytes = Base16.decode(hex).get |
There was a problem hiding this comment.
This .get is not safe, and caught everywhere (and interface method calling it not exposing exceptions). Better return Try[ErgoTree]
There was a problem hiding this comment.
For performance Try is not used in sigma, exceptions are thrown everywhere, which gives good visibility into full stack.
Here, when decode result is Failure, will just throw the actual exception with full stack trace.
Another reason to not use Try here, is because this method is used form JS wrappers (see js.ErgoTree class), and Try has no good JS equivalent (where exceptions are used for errors).
…plement SecureRandom for js Platform
Secure random for JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this release: