Reduction and signing of Fleet transactions #900
Conversation
# Conflicts: # sdk/shared/src/main/scala/org/ergoplatform/sdk/AppkitProvingInterpreter.scala
# Conflicts: # sdk/js/src/main/scala/org/ergoplatform/sdk/js/Isos.scala # sigma-js/package-lock.json
…d and deserialized
sdk/shared/src/main/scala/org/ergoplatform/sdk/multisig/Signer.scala
Outdated
Show resolved
Hide resolved
| * @param softForkVotesCollected votes for soft-fork collected in previous epochs | ||
| * @param blockVersion Protocol version activated on the network | ||
| */ | ||
| case class BlockchainParameters( |
There was a problem hiding this comment.
Why not ErgoParameters ? Parameters are not related to a generic blockchain, rather, the Ergo one (I guess it was named ErgoLikeParameters to support Ergo-like blockchains as well)
There was a problem hiding this comment.
The new name clarifies that it is blockchain parameters (those stored in blockchain), not some other parameters.
The package org.ergoplatform.sdk already suggests it is related to Ergo blockchain, so no need to add Ergo once again.
ErgoLike prefix is pretty useless (ErgoLikeContext doesn't tell anything about what kind of context it is, InterpreterContext is much better).
I was thinking to rename all ErgoLike names at some point as part of further refactoring and code simplification
There was a problem hiding this comment.
So for other Ergo-like blockchains (e.g. sidechains) you will have different packages?
There was a problem hiding this comment.
Yes, probably. Everything in org.ergoplatform is part of reference implementation.
It will depend on how other projects will be architected, as a layer on top of core ergo packages, or as a repo fork with the necessary changes.
...er/shared/src/main/scala/org/ergoplatform/validation/SigmaValidationSettingsSerializer.scala
Show resolved
Hide resolved
In this PR more methods exported to JS: