-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TypeSerializer and DataSerializer to core
module (part 1)
#913
Conversation
core
modulecore
module (part 1)
# Conflicts: # sdk/js/src/main/scala/org/ergoplatform/sdk/js/Isos.scala
# Conflicts: # core/shared/src/main/scala/sigma/Evaluation.scala # interpreter/shared/src/main/scala/sigmastate/eval/CostingDataContext.scala # interpreter/shared/src/main/scala/sigmastate/sigmastate.scala
import sigma.{AvlTree, BigInt, Box, Coll, Colls, Context, Evaluation, GroupElement, Header, PreHeader, SigmaDslBuilder, SigmaProp} | ||
|
||
import java.math.BigInteger | ||
import scala.util.{Failure, Success} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used imports (as well as some others in this file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
import java.math.BigInteger | ||
import scala.util.{Failure, Success} | ||
|
||
/** Base type for all AST nodes of sigma lang. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sigma lang => ErgoTree? What does "sigma lang" mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
/** Representation of type codes used in serialization. */ | ||
type TypeCode = Byte | ||
|
||
val DummyValue = 0.asWrappedType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
/** Costructs a collection type with the given type of elements. */ | ||
implicit def typeCollection[V <: SType](implicit tV: V): SCollection[V] = SCollection[V](tV) | ||
|
||
import SType.{paramIV, paramIVSeq, paramOV} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -0,0 +1,14 @@ | |||
package sigma.ast | |||
|
|||
case class STypeParam( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ScalaDoc missed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
In this PR:
core
modulesigma.ast
package