Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TypeSerializer and DataSerializer to core module (part 1) #913

Merged
merged 13 commits into from
Oct 3, 2023

Conversation

aslesarenko
Copy link
Member

In this PR:

  • SType hierarchy moved to core module sigma.ast package
  • all SMethod setup is moved to MethodsContainer hierarchy

@aslesarenko aslesarenko marked this pull request as draft August 27, 2023 18:28
@aslesarenko aslesarenko changed the title Move TypeSerializer and DataSerializer to core module Move TypeSerializer and DataSerializer to core module (part 1) Sep 10, 2023
@aslesarenko aslesarenko marked this pull request as ready for review September 10, 2023 13:19
@aslesarenko aslesarenko changed the base branch from minimize-modules to v5.0.12-RC September 12, 2023 15:49
# Conflicts:
#	core/shared/src/main/scala/sigma/Evaluation.scala
#	interpreter/shared/src/main/scala/sigmastate/eval/CostingDataContext.scala
#	interpreter/shared/src/main/scala/sigmastate/sigmastate.scala
import sigma.{AvlTree, BigInt, Box, Coll, Colls, Context, Evaluation, GroupElement, Header, PreHeader, SigmaDslBuilder, SigmaProp}

import java.math.BigInteger
import scala.util.{Failure, Success}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used imports (as well as some others in this file)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

import java.math.BigInteger
import scala.util.{Failure, Success}

/** Base type for all AST nodes of sigma lang. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigma lang => ErgoTree? What does "sigma lang" mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

/** Representation of type codes used in serialization. */
type TypeCode = Byte

val DummyValue = 0.asWrappedType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

/** Costructs a collection type with the given type of elements. */
implicit def typeCollection[V <: SType](implicit tV: V): SCollection[V] = SCollection[V](tV)

import SType.{paramIV, paramIVSeq, paramOV}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused imports

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -0,0 +1,14 @@
package sigma.ast

case class STypeParam(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScalaDoc missed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@aslesarenko aslesarenko changed the base branch from v5.0.12-RC to v5.0.13-RC October 3, 2023 10:45
@aslesarenko aslesarenko merged commit 8442400 into v5.0.13-RC Oct 3, 2023
4 checks passed
@aslesarenko aslesarenko deleted the sigma-ast branch May 1, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants