Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Implementation of Numeric.toBigEndianBytes #984

Closed
wants to merge 34 commits into from

Conversation

aslesarenko
Copy link
Member

@aslesarenko aslesarenko commented May 14, 2024

Closes #486
In this PR a new method Numeric.toBigEndianBytes is implemented for Byte, Short, Int, Long, BigInt types.

@aslesarenko aslesarenko added soft-fork Implementation requires soft-fork A-consensus Area: Code used in consensus (i.e. transaction validation) labels May 14, 2024
@aslesarenko aslesarenko added this to the v6.0 milestone May 14, 2024
@aslesarenko aslesarenko marked this pull request as draft May 14, 2024 11:30
@aslesarenko aslesarenko changed the base branch from develop to v6.0.0 May 14, 2024 14:57
@aslesarenko aslesarenko changed the title Implementation of Numeric.toBytes [6.0] Implementation of Numeric.toBytes May 14, 2024
@aslesarenko aslesarenko changed the base branch from v6.0.0 to v6.0.0-refactor-ir-cake May 16, 2024 16:27
@aslesarenko aslesarenko changed the title [6.0] Implementation of Numeric.toBytes [6.0] Implementation of Numeric.toBigEndianBytes May 23, 2024
@aslesarenko aslesarenko linked an issue May 23, 2024 that may be closed by this pull request
@aslesarenko aslesarenko changed the base branch from v6.0.0-refactor-ir-cake to i994-fix-subst-constants May 23, 2024 15:52
…tants' into i486-toBytes

# Conflicts:
#	sc/shared/src/test/scala/sigma/LanguageSpecificationV5.scala
#	sc/shared/src/test/scala/sigmastate/lang/SigmaTyperTest.scala
@aslesarenko aslesarenko linked an issue May 25, 2024 that may be closed by this pull request
2 tasks
@aslesarenko aslesarenko self-assigned this May 25, 2024
@aslesarenko aslesarenko marked this pull request as ready for review June 5, 2024 13:08
@aslesarenko aslesarenko requested a review from kushti June 5, 2024 13:08
@kushti kushti changed the base branch from i994-fix-subst-constants to v6.0-newfeature June 7, 2024 09:22
Base automatically changed from v6.0-newfeature to v6.0.0 June 9, 2024 08:53
@kushti
Copy link
Member

kushti commented Sep 12, 2024

Merged into #1017

@kushti kushti closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Code used in consensus (i.e. transaction validation) soft-fork Implementation requires soft-fork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MethodCall encoding of Numeric methods Add Numeric.toBigEndianBytes methods
2 participants