-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0] Global.serialize method #989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are not enough tests:
- do (de)serialization test for the new methods call in MethodCallSerializerSpecification
- do serialize - deserialize roundtrip test
- test newly supported data types , namely Header and Option[], explicitly , but better to test more , see BasicOpsSpecification in deserialize PR
Do you suggest to base this PR on top of #979? |
Sure, how else can you check the roundtrip . Also, new serializers (Header & Option) are there |
Ok, then this can be postponed until:
|
There is no need to wait for merge of #979. Actually, this PR and #979 will be likely merged about the same time. |
…preter into v6.0-serialize
TODO:
|
Please clarify:
Also, please fix the tests. |
@ergomorphic those are notes for myself, the PR is not finished, please review finished PRs! In particular, to fix the tests, #972 with Header serialization should be merged into v6.0.0 branch and then this PR. |
@kushti, LGTM, cannot approve my own PR, consider approved. |
In this PR: