Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reread config file on each pass of plot loop #707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wtfrank
Copy link

@wtfrank wtfrank commented May 30, 2021

Allows settings such as number of threads to be tweaked without restarting "plotman plot".

allows settings such as number of threads to be tweaked without
restarting plotman
@altendky
Copy link
Collaborator

This would at least need to be configurable. I share my configs between multiple machines and use git to transfer between and so various changes could get loaded that do not make sense while I am processing through that. Also, what should happen if the reload fails?

@mk01
Copy link
Contributor

mk01 commented Jul 6, 2021

@altendky
of course old config should be retained.

            try:
                newcfg = configuration.get_validated_configs(configuration.read_configuration_text(config_path), config_path)
                cfg = newcfg
            except Exception as ex:
                print('... while reloading config: %s' % (str(ex)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants