issue-link js-issue-link" data-error-text="Failed to load title" data-id="907549656" data-permission-text="Title is private" data-url="https://github.com/ericaltendorf/plotman/issues/712" data-hovercard-type="issue" data-hovercard-url="/ericaltendorf/plotman/issues/712/hovercard" href="https://github.com/ericaltendorf/plotman/issues/712">ericaltendorf#712, ericaltendorf#711, ericaltendorf#677, ericaltendorf#638, ericaltendorf#582 ..., - process cpu and io niceness can also be manipulated, affinity to cpu or NUMA on big server hardware can be set differently based on stage or plotter - all new code is in new library 'hooks' + two new shell scripts directly inside hooks.d directory (located inside plotman's own config directory - supplied hook serves as reference implementation / example, providing functionality for ericaltendorf#677 - modification of existing plotman's code is only to call entrypoint in hooks.py and pass current jobs list containing jobs objects - currently manager.py maybe_start_new_plot() and plotman.py kill is injected with call into hooks.try_run() and hooks.run() respectively - try_run consumes fully refreshed jobs[], compares phase to previous job phase and if it is changed, calls hooks.run() - run() takes plotmans environment, extends it with particular job's metadata and calls all executable files from hooks.d directory having extension .sh or .py - scripts are called synchronously, cmd exec is waiting until the script process returns. that means the implementation is not suitable for LONG running actions. - anyhow, plotman CLI can be called without issues from within the hooks, recursion in job_refresh -> try_run -> hooks script -> plotman cmd is being checked for new: src/plotman/hooks.py src/plotman/resources/hooks.d update: src/plotman/configuration.py src/plotman/manager.py setup.cfg

Commits

Commits on Jul 4, 2021

- implement hooks

- add some sanitization / checks to ENV variables needed for proper

- add simple "hello world" kind of hook which logs new plotting process

- implement post kill cleanup based on plotid wildcard search