Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#253 Fix issue with always defined defaultLayout property which alway… #254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Romick2005
Copy link

…s render default view, but the one that was specified to render.

…always render default view, but the one that was specified to render.
@jfbrennan
Copy link
Contributor

The default is by design, but apparently should have been released as a major since some use cases aren't using a layout at all. The fix for those apps is exphbs({defaultLayout: null})

@ismail-codinglab
Copy link

ismail-codinglab commented Sep 19, 2019

@jfbrennan The behavior of the API has changed, causing untouched code to no longer work. A fix should be implemented that will behave the same.

I do not want to touch my code for something that should not be our issue

@UziTech
Copy link

UziTech commented Sep 19, 2019

@ismail-codinglab This project isn't updated very often so if you want to wait for a fix you might be waiting a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants