sp_QuickieStore.sql: Moved capturing of _date_original variables outside of loop. #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #429 . As with the last
@get_all_databasesbug, I just had to move some bits outside of the loop and make something inside of the loop point to the now-outside bits. I think I'm finding one@get_all_databases-bug per month, which is a bit worrying.As always, I must warn that I have never taken a deep look at how this procedure works, so I may have totally messed it up. It's clear that the date/UTC handling in this procedure is battle-worn, so it really is quite likely that I'm oblivious to something important. I have tried my best to make small changes that are true to the design and formatting, but this time it was worryingly easy. I was shocked to see that the
@[...]_date_originalvariables already existed. It's as if somebody already tried to patch this bug.