Ersilia Catalog Bug when no models are available #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhanshreeA
requested changes
Jun 26, 2024
ersilia/cli/commands/catalog.py
Outdated
| @@ -1,6 +1,7 @@ | |||
| import click | |||
|
|
|||
| from . import ersilia_cli | |||
| from .. import echo | |||
There was a problem hiding this comment.
Where are we using this after the import?
There was a problem hiding this comment.
Oh! I was only trying something out,forgot to remove it
ersilia/cli/commands/catalog.py
Outdated
| @@ -43,15 +45,25 @@ def catalog(local=False, file_name=None, browser=False, more=False): | |||
| mc.airtable() | |||
| return | |||
| if local: | |||
| catalog_table = mc.local() | |||
There was a problem hiding this comment.
I like your use of storing mc.local and mc.hub into a catalog_table variable. Could we maybe rewrite this whole bit as:
catalog_table = mc.local() if local else mc.hub()
if file_name is None:
catalog = catalog_table.as_json()
else:
catalog_table.write(file_name)
catalog = None
DhanshreeA
approved these changes
Jun 26, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you try to run ersilia catalog --local but no models are available locally, instead of telling you there is no local model available, it outputs an error:
Changes Made
-updated the
localmethod to return an emptycatalogue_tableif no models are found.-updated the
cataloguecommand to print a message when thecatalogue_tablehas no dataStatus
"No local model is available. Please fetch a model by running 'ersilia fetch ...'" is returned when you run
ersilia catalog --localand no local model is availableRelated to #1072