Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate GDI inference store with CLI #1190

Merged
merged 13 commits into from
Oct 24, 2024
Merged

Integrate GDI inference store with CLI #1190

merged 13 commits into from
Oct 24, 2024

Conversation

nicholas-kondal
Copy link
Contributor

@nicholas-kondal nicholas-kondal commented Jul 7, 2024 •
edited
Loading

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

Allow precalculations to be read from Ersilia's AWS cloud environment via https://github.com/ersilia-os/model-inference-pipeline

Status

  • Select the source of outputs during model serving
  • Upload input molecules to the cloud and retrieve ecalculations via a secure S3 download link
  • Provide warnings and errors in case models and/or precalculations are not currently present in the cloud

To do

See ersilia-os/model-inference-pipeline#32 for next steps

@DhanshreeA DhanshreeA force-pushed the master branch 3 times, most recently from 024be81 to 3a4af82 Compare July 10, 2024 09:01
@DhanshreeA DhanshreeA force-pushed the master branch 3 times, most recently from 2974b29 to a07c583 Compare July 10, 2024 16:55
DhanshreeA and others added 2 commits July 26, 2024 17:30
@DhanshreeA
Enable Ersilia to serve multiple models simultaneously (#1201)
552b053 
* WIP Add session management utils

* Create a session at ersilia cli initialization

* Remove unused code

* start an ersilia session in a dedicated sessions dir that is mapped to the parent process' id which ran the given ersilia command, this will generally be a shell process inside a terminal, but it can also be a process from a bash script

* declare session specific defaults

* Run all ersilia commands within a single process during standard example run, otherwise ersilia run command does not find a served model bec of running in a different process and therefore in a different session

* Move the currently served model's pid to its dedicated session directory

* WIP Logging

* Redirect tmp logs to model's session logs

* catch permission error

* Redirect tmp logs to model's session logs

* don't use ersilia exception management because we don't exactly want the ersilia process to exit
@nicholas-kondal
Merge branch 'master' into inference-store-integration
555bd42
@nicholas-kondal nicholas-kondal mentioned this pull request Sep 29, 2024
Merged
@github-actions github-actions bot force-pushed the master branch 2 times, most recently from 471121a to 3138390 Compare October 1, 2024 03:17
@DhanshreeA DhanshreeA force-pushed the master branch 2 times, most recently from 900abaf to 01960ed Compare October 1, 2024 05:20
@miquelduranfrigola
Copy link
Member

@DhanshreeA and @kartikey-vyas - plesae let me know when will this be ready for merge?

@kartikey-vyas kartikey-vyas marked this pull request as ready for review October 20, 2024 05:41
@kartikey-vyas
Copy link
Contributor

We are ready for review here, with the IaC written in the model inference repo

@miquelduranfrigola
Copy link
Member

@Abellegese @DhanshreeA we need to merge this PR. There are conflicts with the api.py, probably due to the latest changes from @Abellegese . Let's try to resolve these conflicts. Many thanks!

@DhanshreeA
Copy link
Member

@miquelduranfrigola we have actually removed the ersilia/cli/commands/api.py file during the process of removing the api command from the CLI in favor of only keeping the run command. Ref: #1263

I'll remove that file from this PR, and review it. cc: @kartikey-vyas hope the inference pipeline doesn't rely on this command?

@DhanshreeA DhanshreeA merged commit b270134 into master Oct 24, 2024
21 checks passed
@DhanshreeA DhanshreeA deleted the inference-store-integration branch October 24, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhanshreeA DhanshreeA DhanshreeA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicholas-kondal @miquelduranfrigola @kartikey-vyas @DhanshreeA