-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate setup to poetry #790
Conversation
JSON and YAML Validation ResultsYAML Validation Results
Violations: [
{
"file": "./.github/workflows/install.yml",
"errors": [
{
"path": null,
"message": "Invalid YAML"
}
]
}
] |
Hi @DhanshreeA I see workflows crashing - most notably, the json syntax checker. Any idea? I have limited bandwidth today to check |
This PR #793 is also failing the syntax check for the installs.yml file - I see your latest push @miquelduranfrigola did changes to the file, I'll try to amend it |
Can you correct the |
c6eca95
to
5e9501c
Compare
a48060a
to
f6375e4
Compare
5e9501c
to
31f6a60
Compare
Currently stuck at figuring out why bentoml installation is not working within tests. 😅 because supposedly the bentoml package can't be found within the environment. However, when I perform an installation locally in a fresh environment, I am able to use the bentoml cli command just fine. |
@miquelduranfrigola @GemmaTuron this is fixed, and ready for review. When you merge this, please squash and merge 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Let's give it a try!
pyproject.toml
to mimic setup in setup.py