Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate setup to poetry #790

Merged
merged 11 commits into from
Aug 31, 2023
Merged

Migrate setup to poetry #790

merged 11 commits into from
Aug 31, 2023

Conversation

DhanshreeA
Copy link
Member

@DhanshreeA DhanshreeA commented Aug 28, 2023

  • Added pyproject.toml to mimic setup in setup.py
  • Updated tag to version workflow to auto update version in pyproject.toml
  • Updated python publish workflow to build with poetry instead of setup.py. By default poetry builds both source and binary distributions (I think I need to update the python image used in this workflow to actually contain poetry 😅 )

@github-actions
Copy link
Contributor

JSON and YAML Validation Results

YAML Validation Results

  • ✅ File(s) Passed: 18
  • ❌ File(s) Failed: 1
  • ⏭️ File(s) Skipped: 7

Violations:

[
  {
    "file": "./.github/workflows/install.yml",
    "errors": [
      {
        "path": null,
        "message": "Invalid YAML"
      }
    ]
  }
]

@DhanshreeA DhanshreeA changed the title Migrate setup to poetry WIP: Migrate setup to poetry Aug 28, 2023
@DhanshreeA DhanshreeA marked this pull request as draft August 28, 2023 09:47
@DhanshreeA DhanshreeA self-assigned this Aug 28, 2023
@DhanshreeA DhanshreeA removed the request for review from GrantBirki August 28, 2023 09:58
@miquelduranfrigola
Copy link
Member

Hi @DhanshreeA I see workflows crashing - most notably, the json syntax checker. Any idea? I have limited bandwidth today to check

@GemmaTuron
Copy link
Member

This PR #793 is also failing the syntax check for the installs.yml file - I see your latest push @miquelduranfrigola did changes to the file, I'll try to amend it

@GemmaTuron
Copy link
Member

@DhanshreeA

Can you correct the installs.yml file in your branch? It won't pass the test otherwise. The right version is now on main

@DhanshreeA
Copy link
Member Author

DhanshreeA commented Aug 30, 2023

Currently stuck at figuring out why bentoml installation is not working within tests. 😅 because supposedly the bentoml package can't be found within the environment. However, when I perform an installation locally in a fresh environment, I am able to use the bentoml cli command just fine.

@DhanshreeA DhanshreeA marked this pull request as ready for review August 31, 2023 10:06
@DhanshreeA DhanshreeA changed the title WIP: Migrate setup to poetry Migrate setup to poetry Aug 31, 2023
@DhanshreeA
Copy link
Member Author

DhanshreeA commented Aug 31, 2023

@miquelduranfrigola @GemmaTuron this is fixed, and ready for review. When you merge this, please squash and merge 🙏

Copy link
Member

@miquelduranfrigola miquelduranfrigola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Let's give it a try!

@miquelduranfrigola miquelduranfrigola merged commit e3c5d79 into master Aug 31, 2023
17 checks passed
@miquelduranfrigola miquelduranfrigola deleted the migrate-setup-to-poetry branch August 31, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants