Skip to content

Commit

Permalink
Merge pull request #21 from eruptionjs/v1.3
Browse files Browse the repository at this point in the history
v1.3
  • Loading branch information
devmozao authored Jan 13, 2023
2 parents 6561e00 + f68118e commit 4cdbce8
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
26 changes: 26 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Changelog

## v1.0.0

. Eruption First Release.
༼ つ ◕_◕ ༽つ🌋

## v1.1.0

. Vite depedency updated to from v2 to v3.
. Fixed missing .sh files for husky pre-commit and commit-msg hook.
. Added missing config for promp-cli at commitlint.

## v1.2.0

. Added msw as a dev dep, but still missing default config
. Changed minor configs to match vite@latest with focus on DX

## v1.3.0

. Upgraded Node to latest LTS version, v18 (hydrogen)
. Upgraded Vite to v4.
. Changed vite-react plugin to vite-react-swc
. Bumped dev dependencies to latest

PS: Know issue on vitest/globals conflicting with testing-lib/jest-dom when running for build/preview scripts. Solutions provided were not sufficient to keep both globals working properly. As a fix, `"skipLibCheck": true,` from `tsconfig.json` was changed to `false`, in order to keep running those scripts.
2 changes: 1 addition & 1 deletion readme.md → README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ To commit, you must follow the convention `<type>[optional scope]: <description>
git commit -m "feat: add button component"
```

Then, Husky will start the pre-commit hook and run lint-staged, who will run `prettier` and `lint` to validate code format and code lint. If you fail to follow any one of these validations above, the commit will be aborted.
Then, Husky will start the pre-commit hook and run lint-staged, who will run `prettier`, `lint` and `stylelint` to validate code format and code lint. If you fail to follow any one of these validations above, the commit will be aborted.

After that, if everything is validated correctly, Husky will proceed with the commit-msg hook, where he will evaluate if your commit message is following the Conventional Commit's best practice and will run the tests of your project. If any of the tests are broken, the commit will be aborted. You must fix the tests before proceeding.

Expand Down

0 comments on commit 4cdbce8

Please sign in to comment.