Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proper syntax highlighting for returned data #624

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

erwindon
Copy link
Owner

@erwindon erwindon commented Aug 11, 2024

Is your feature request related to a problem? Please describe.
SaltGui shows (structured) results in a plain way. A few low-level formatting tricks are use to format it.

Describe the solution you'd like
Use library that can do syntax highlighting on data.

Additional context

  • library must be free to use
  • library must be simple to use
  • library must be small (as shipped)

@erwindon
Copy link
Owner Author

erwindon commented Aug 11, 2024

use https://highlightjs.org/
download a bundle with only json and yaml (nested will use yaml)

@erwindon erwindon force-pushed the highlightjs branch 6 times, most recently from 7e26fb1 to 84fa546 Compare August 11, 2024 18:27
@erwindon erwindon force-pushed the highlightjs branch 4 times, most recently from 9a05080 to 271ebac Compare October 25, 2024 18:51
Repository owner deleted a comment from sonarqubecloud bot Oct 25, 2024
@erwindon erwindon marked this pull request as ready for review October 25, 2024 19:01
@erwindon erwindon force-pushed the highlightjs branch 5 times, most recently from 6ef0104 to 914f76a Compare November 2, 2024 22:45
Copy link

sonarqubecloud bot commented Nov 2, 2024

Copy link

sonarqubecloud bot commented Dec 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant