clean-up clangd suggestions

esa · Oct 4, 2023 · 9d86815 · 9d86815
1 parent 2c02d90
commit 9d86815
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/include/kep3/epoch.hpp b/include/kep3/epoch.hpp
@@ -127,8 +127,7 @@ class kep3_DLL_PUBLIC epoch
     }
 
     // Constructor for datetime broken down into its constituents.
-    explicit epoch(const int y, const uint mon, const uint d, const int h = 0, const int min = 0, const int s = 0,
-                   const int ms = 0, const int us = 0);
+    explicit epoch(int y, uint mon, uint d, int h = 0, int min = 0, int s = 0, int ms = 0, int us = 0);
 
     /* Computing non-Gregorian dates */
 
@@ -159,8 +158,8 @@ class kep3_DLL_PUBLIC epoch
     }
 
     /* Helper functions for constructors */
-    static kep_clock::time_point make_tp(const int y, const uint mon, const uint d, const int h = 0, const int min = 0,
-                                         const int s = 0, const int ms = 0, const int us = 0);
+    static kep_clock::time_point make_tp(int y, uint mon, uint d, int h = 0, int min = 0,
+                                         int s = 0, int ms = 0, int us = 0);
 
     static kep_clock::time_point make_tp(double epoch_in, julian_type epoch_type);
 
@@ -174,7 +173,7 @@ class kep3_DLL_PUBLIC epoch
     }
 
     // Printing
-    std::string as_utc_string() const;
+    [[nodiscard]] std::string as_utc_string() const;
     static std::string as_utc_string(const kep_clock::time_point &tp);
 
     /** operator overloads for sum and diff (epoch-days) and comparison

diff --git a/include/kep3/lambert_problem.hpp b/include/kep3/lambert_problem.hpp
@@ -71,7 +71,7 @@ class kep3_DLL_PUBLIC lambert_problem
     void dTdx(double &, double &, double &, double, double) const;
     void x2tof(double &tof, double x0, unsigned N) const;
     void x2tof2(double &tof, double x0, unsigned N) const;
-    [[nodiscard]] double hypergeometricF(double z, double tol) const;
+    [[nodiscard]] static double hypergeometricF(double z, double tol);
     friend class boost::serialization::access;
     template <class Archive>
     void serialize(Archive &ar, const unsigned int)

diff --git a/src/epoch.cpp b/src/epoch.cpp
@@ -69,7 +69,7 @@ epoch::epoch(const kep_clock::time_point &time_point) : tp{time_point} {}
  *
  * @param[in] time_point Self-explanatory.
  */
-epoch::epoch(kep_clock::time_point &&time_point) : tp{std::move(time_point)} {}
+epoch::epoch(kep_clock::time_point &&time_point) : tp{time_point} {}
 
 kep_clock::time_point epoch::make_tp(const int y, const uint mon, const uint d, const int h, const int min, const int s,
                                      const int ms, const int us)

diff --git a/src/lambert_problem.cpp b/src/lambert_problem.cpp
@@ -273,7 +273,7 @@ void lambert_problem::x2tof(double &tof, double x, unsigned N) const
     }
 }
 
-double lambert_problem::hypergeometricF(double z, double tol) const
+double lambert_problem::hypergeometricF(double z, double tol) // NOLINT
 { // NOLINT
     double Sj = 1.0;
     double Cj = 1.0;