Merge pull request #273 from esek/feature/hehe-page

add pdf to png secret
esek · May 31, 2024 · 2083191 · 2083191
2 parents 733944d + ded3983
commit 2083191
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/docker.yaml b/.github/workflows/docker.yaml
@@ -242,6 +242,7 @@ jobs:
             kv/data/${{ needs.env-vars.outputs.basename }}/${{ needs.env-vars.outputs.env }} JWT_SECRET;
             kv/data/${{ needs.env-vars.outputs.basename }}/${{ needs.env-vars.outputs.env }} EBREV;
             kv/data/${{ needs.env-vars.outputs.basename }}/${{ needs.env-vars.outputs.env }} EBREV_API_TOKEN;
+            kv/data/${{ needs.env-vars.outputs.basename }}/${{ needs.env-vars.outputs.env }} PDF_TO_PNG_BASE_URL;
       - name: set variables
         run: |
           echo "IMAGE_NAME=${{ needs.env-vars.outputs.image_name }}" >> $GITHUB_ENV

diff --git a/CHANGELOG.MD b/CHANGELOG.MD
@@ -5,7 +5,7 @@ Alla märkbara ändringar ska dokumenteras i denna fil.
 Baserat på [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 och följer [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [1.10.0] - 2024-04-29
+## [1.10.0] - 2024-05-31
 
 ### Tillagt
 
@@ -20,6 +20,7 @@ och följer [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 - Enhetstest för Hehe som kontrollerar att en felaktig filtyp inte kan laddas upp
 - Enhetstester för `paginatedHehes`
 - Enhetstester för `createPageInfo`
+- Environment-variabeln `PDF_TO_PNG_BASE_URL`
 
 ### Ändrat
 

diff --git a/docker-compose.ci.yml b/docker-compose.ci.yml
@@ -14,6 +14,7 @@ services:
       - JWT_SECRET
       - EBREV
       - EBREV_API_TOKEN
+      - PDF_TO_PNG_BASE_URL
     networks:
       - traefik
       - default # to join compose network

diff --git a/test/integration/hehe.test.ts b/test/integration/hehe.test.ts
@@ -5,7 +5,6 @@ import { HeheAPI } from '@api/hehe';
 import { AccessType, Feature, File, FileType } from '@generated/graphql';
 import { removeUploadedFiles, UploadFileOptions, baseUploadFile } from '@test/utils/fileUpload';
 import { genRandomUser } from '@test/utils/utils';
-import path from 'path';
 import request from 'supertest';
 
 const heheApi = new HeheAPI();
@@ -66,5 +65,5 @@ test('create HeHE cover image from PDF', async () => {
   });
 
   // Cover test file must be deleted manually as it is not created by the uploadFile function
-  fileApi.deleteFile(coverId);
+  await fileApi.deleteFile(coverId);
 });