fix: issue with edge case escape character, enhance tests

eshaz · Jan 13, 2024 · 3f87552 · 3f87552
1 parent d105f30
commit 3f87552
Show file tree

Hide file tree

Showing 7 changed files with 182 additions and 151 deletions.
diff --git a/dist/esm.js b/dist/esm.js
diff --git a/dist/index.js b/dist/index.js
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "simple-yenc",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "Minimalist yEnc and dynEncode encoder and decoder library for browser and NodeJS",
   "main": "./dist/index.js",
   "module": "./dist/esm.js",

diff --git a/src/simple-yenc.js b/src/simple-yenc.js
@@ -284,9 +284,9 @@ const dynamicEncode = (
   }
 
   // correct edge case where escape character is at end of string
-  if (charArray[charArray.length - 1] === "\\" && shouldEscape(92)) {
+  if (charArray[charArray.length - 1] === "\\") {
     charArray.pop();
-    escapeCharacter("\\", charArray);
+    escapeCharacter(92, charArray);
   }
 
   return charArray.join("");

diff --git a/test/offset_test.bin b/test/offset_test.bin