Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Modified Player Search Screen (1) #101

Merged
merged 6 commits into from
Jul 13, 2024
Merged

[FEATURE] Modified Player Search Screen (1) #101

merged 6 commits into from
Jul 13, 2024

Conversation

eshc123
Copy link
Owner

@eshc123 eshc123 commented Jul 12, 2024

Description

  1. 수정된 디자인에 따른 UI 변경

Content

  1. 선수 검색 화면을 수정하였습니다.

Comment

  1. 필터, 정렬 및 선수 클릭 시 화면 전환은 다음 작업으로 나누어서 진행하겠습니다.
  2. 선수 검색 시 검색어 관련해서 (TeamSearchViewModel의 query 등) https://medium.com/androiddevelopers/effective-state-management-for-textfield-in-compose-d6e5b070fbe5 를 참고하였습니다.

Screenshot

@eshc123 eshc123 added the feature New feature or request label Jul 12, 2024
@eshc123 eshc123 requested a review from KanuKim97 July 12, 2024 10:06
@eshc123 eshc123 self-assigned this Jul 12, 2024
KanuKim97
KanuKim97 approved these changes Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@KanuKim97 KanuKim97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@eshc123 eshc123 merged commit aa22165 into dev Jul 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KanuKim97 KanuKim97 KanuKim97 approved these changes

Assignees

@eshc123 eshc123

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshc123 @KanuKim97