[FEATURE] Modified Player Detail Screen (1) #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KanuKim97
reviewed
Apr 30, 2024
core/designsystem/src/main/java/com/eshc/goonersapp/core/designsystem/component/Tab.kt
Outdated
Show resolved
Hide resolved
feature/team/src/main/java/com/eshc/goonersapp/feature/team/detail/PlayerDetailScreen.kt
Outdated
Show resolved
Hide resolved
feature/team/src/main/java/com/eshc/goonersapp/feature/team/detail/PlayerDetailScreen.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Content
Result screenshot
Comment
해당 화면에서 풀스크린으로 가져가야 할 것 같은데, 해당 화면에서만 컨트롤하는 것이 아니라 최상위 Composable인 GnrApp 에서의 padding도 컨트롤이 필요할 것 같아 이 부분은 더 고민 후 이후에 추가로 작업 진행하겠습니다.