Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Modified Team Screen #74

Merged
merged 3 commits into from
May 4, 2024
Merged

[FEATURE] Modified Team Screen #74

merged 3 commits into from
May 4, 2024

Conversation

eshc123
Copy link
Owner

@eshc123 eshc123 commented May 4, 2024

Description

  • 수정된 디자인에 따른 TeamScreen UI 수정

Content

  1. PlayerCard 수정
  2. PlayerCard에서 선수별 나라 이미지는 현재 API에 포함되어 있지 않아 제외하였습니다.
  3. TopBar와 시즌 선택 dropdown 관련 내용은 이번 PR에 포함되어 있지 않습니다.

Result screenshot

@eshc123 eshc123 requested a review from KanuKim97 May 4, 2024 02:36
@eshc123 eshc123 self-assigned this May 4, 2024
KanuKim97
KanuKim97 approved these changes May 4, 2024
View reviewed changes
Copy link
Collaborator

@KanuKim97 KanuKim97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 확인했습니다! @eshc123
고생하였어요! 👍

@KanuKim97 KanuKim97 merged commit 8f77d8a into dev May 4, 2024
1 check passed
@eshc123 eshc123 deleted the feature/mod-team-screen branch May 6, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KanuKim97 KanuKim97 KanuKim97 approved these changes

Assignees

@eshc123 eshc123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshc123 @KanuKim97